Ensure that a failed deployment is not created #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
commented
Jun 13, 2024
| @@ -268,6 +268,8 @@ def _run_in_transaction(self, **kwargs): # pylint: disable=too-many-branches, t | |||
| This version of `run` is wrapped in a transaction and will roll back database changes | |||
| on error. In general, this method should only be called by the `run` method. | |||
| """ | |||
| sid = transaction.savepoint() | |||
There was a problem hiding this comment.
@abates , I think that is a better approach to rollback all the changes from a Design Job if it fails.
This means that neither a Deployment or a ChangeSet will be created if it fails or it's run in dry run mode.
abates
approved these changes
Jun 13, 2024
abates
pushed a commit
that referenced
this pull request
Jun 24, 2024
* tests: add a test to make sure that a failed deployment is not created * fix: rollback the whole changes in a Design Job if something fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #170